version 2.7

correction bug on detection of already downloaded file

RsyncUI.pro

@@ -29,6 +29,7 @@ HEADERS += \
 FORMS += \
     about.ui \
     configuration.ui \
+    login.ui \
     mainwindow.ui
 
 TRANSLATIONS += \

RsyncUI.pro.user

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE QtCreatorProject>
-<!-- Written by QtCreator 4.14.2, 2023-02-22T00:23:04. -->
+<!-- Written by QtCreator 4.14.2, 2023-03-02T17:04:47. -->
 <qtcreator>
  <data>
   <variable>EnvironmentId</variable>

RsyncUI.spec

@@ -2,7 +2,7 @@
 
 Name: rsyncui
 Summary: Client for rsync server
-Version: 2.5
+Version: 2.7
 Release: %mkrel 1
 License: GPLv3
 Group: Networking/Remote access

RsyncUI_fr_FR.ts

@@ -66,6 +66,34 @@
         <translation>Enregistrement automatique de la file d&apos;enregistrement</translation>
     </message>
 </context>
+<context>
+    <name>LoginDialog</name>
+    <message>
+        <location filename="login.ui" line="17"/>
+        <source>RsyncUI request</source>
+        <translation>Requête RsyncUI</translation>
+    </message>
+    <message>
+        <location filename="login.ui" line="51"/>
+        <source>Login name</source>
+        <translation>Identifiant</translation>
+    </message>
+    <message>
+        <location filename="login.ui" line="79"/>
+        <source>Enter login</source>
+        <translation>Entrez votre identifiant</translation>
+    </message>
+    <message>
+        <location filename="login.ui" line="86"/>
+        <source>Password</source>
+        <translation>Mot de passe</translation>
+    </message>
+    <message>
+        <location filename="login.ui" line="102"/>
+        <source>Enter password</source>
+        <translation>Entrez votre mot de passe</translation>
+    </message>
+</context>
 <context>
     <name>MainWindow</name>
     <message>
@@ -137,78 +165,85 @@
         <translation>Barre d&apos;outils</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="448"/>
+        <location filename="mainwindow.ui" line="449"/>
         <source>Download</source>
         <translation>Télécharger</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="451"/>
+        <location filename="mainwindow.ui" line="452"/>
         <source>Click on menu button to download the entire folder</source>
         <translation>Cliquer sur le bouton droit de la souris pour télécharger le dossier entier</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="460"/>
+        <location filename="mainwindow.ui" line="461"/>
         <source>Exit</source>
         <translation>Quitter</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="463"/>
+        <location filename="mainwindow.ui" line="464"/>
         <source>Terminate the program</source>
         <translation>Terminer le programme</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="466"/>
+        <location filename="mainwindow.ui" line="467"/>
         <source>Ctrl+Q</source>
         <translation>Ctrl+Q</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="413"/>
-        <location filename="mainwindow.ui" line="416"/>
+        <location filename="mainwindow.ui" line="475"/>
+        <source>hidden service</source>
+        <translation>entre
+
+Service caché</translation>
+    </message>
+    <message>
+        <location filename="mainwindow.ui" line="414"/>
+        <location filename="mainwindow.ui" line="417"/>
         <source>Change save folder</source>
         <translation>Changer le dossier de destination</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="425"/>
+        <location filename="mainwindow.ui" line="426"/>
         <source>About</source>
         <translation>À propos</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="434"/>
+        <location filename="mainwindow.ui" line="435"/>
         <source>About Qt</source>
         <translation>À propos de Qt</translation>
     </message>
     <message>
-        <location filename="mainwindow.ui" line="443"/>
+        <location filename="mainwindow.ui" line="444"/>
         <source>Settings</source>
         <translation>Paramètres</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="102"/>
+        <location filename="mainwindow.cpp" line="107"/>
         <source>KB</source>
         <translation>Ko</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="102"/>
+        <location filename="mainwindow.cpp" line="107"/>
         <source>MB</source>
         <translation>Mo</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="102"/>
+        <location filename="mainwindow.cpp" line="107"/>
         <source>GB</source>
         <translation>Go</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="102"/>
+        <location filename="mainwindow.cpp" line="107"/>
         <source>TB</source>
         <translation>To</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="102"/>
+        <location filename="mainwindow.cpp" line="107"/>
         <source>PB</source>
         <translation>Po</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="57"/>
+        <location filename="mainwindow.cpp" line="61"/>
         <source>You click on file to enqueue it, and RyncUI Download one file a time</source>
         <oldsource>Client for rsync server&lt;br&gt;&lt;br&gt;You click on file to enqueue it, and RyncUI Download one file a time</oldsource>
         <translation>&lt;h3&gt;Utilisation&lt;/h3&gt;
@@ -245,185 +280,201 @@ Cliquez sur un fichier pour le supprimer de la file et une fenêtre de confirmat
         <translation type="vanished">&lt;h2&gt;Client pour  serveur rsync&lt;2&gt;&lt;br&gt;&lt;br&gt;éaa</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="73"/>
+        <location filename="mainwindow.cpp" line="78"/>
         <source>Path</source>
         <translation>Chemin</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="73"/>
+        <location filename="mainwindow.cpp" line="78"/>
         <source>Size</source>
         <translation>Taille</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="73"/>
+        <location filename="mainwindow.cpp" line="78"/>
         <source>Type</source>
         <translation>Type</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="117"/>
+        <location filename="mainwindow.cpp" line="122"/>
         <source>A list of interrupted downloads exists, do you want to continue downloading ? if not the list will be cleared</source>
         <translation>Une liste de téléchargement existe, voulez-vous utiliser cette liste ? si non, elle sera effacée</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="146"/>
+        <location filename="mainwindow.cpp" line="151"/>
         <source>&amp;Quit</source>
         <translation>&amp;Quitter</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="203"/>
+        <location filename="mainwindow.cpp" line="208"/>
         <source>Clicking Save button, You can save the list of downloads
 </source>
         <translation>Vous pouvez enregistrer la liste des téléchargements en cliquant sur &quot;enregister&quot;
 </translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="209"/>
+        <location filename="mainwindow.cpp" line="214"/>
         <source>Exiting will stop downloading, and will clear the download queue.
 Do you want to exit ?</source>
         <translation>Si vous sortez, les téléchargements seront arrêter.
 Voulez-vous vraiment sortir ?</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="247"/>
+        <location filename="mainwindow.cpp" line="252"/>
         <source>The program will keep running in the system tray. To terminate the program, choose &lt;b&gt;Quit&lt;/b&gt; in the context menu of the system tray entry.</source>
         <translation>Le programme continue dans la boîte à miniatures. Pour quitter le programme cliquez sur l&apos;icône &lt;b&gt;Quitter&lt;/b&gt; ou dans les menu contextuel.</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="540"/>
+        <location filename="mainwindow.cpp" line="501"/>
+        <source>The processus does&apos;nt respond: </source>
+        <translation>Le processus ne répond pas: </translation>
+    </message>
+    <message>
+        <location filename="mainwindow.cpp" line="587"/>
         <source>server does not exists</source>
         <translation>Le serveur n&apos;existe pas</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="567"/>
-        <location filename="mainwindow.cpp" line="587"/>
+        <location filename="mainwindow.cpp" line="615"/>
+        <location filename="mainwindow.cpp" line="635"/>
         <source>Dir</source>
         <translation>dossier</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="571"/>
-        <location filename="mainwindow.cpp" line="657"/>
+        <location filename="mainwindow.cpp" line="619"/>
+        <location filename="mainwindow.cpp" line="639"/>
+        <location filename="mainwindow.cpp" line="740"/>
         <source>File</source>
         <translation>Doc</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="668"/>
+        <location filename="mainwindow.cpp" line="768"/>
         <source>File is partially downloaded. Do you want to resume download ? if no, the file will be deleted from destination directory</source>
         <translation>Le document est déjà partiellement téléchargé. Voulez vous continuer le téléchargemnt ? Si non, il sera supprimer du dossier de destination</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="685"/>
+        <location filename="mainwindow.cpp" line="785"/>
         <source>File is already downloaded. Do you want to reload it ? The old file will be deleted</source>
         <translation>Le document est déjà téléchargé. Voulez-vous le télécharger à nouveau ? L&apos;ancien fichier sera effacé</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="722"/>
+        <location filename="mainwindow.cpp" line="822"/>
         <source>File is already downloading</source>
         <translation>Le document est déjà en téléchargement</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="745"/>
+        <location filename="mainwindow.cpp" line="847"/>
         <source>Starting downloading
 </source>
         <translation>Démarrage du téléchargement
 </translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="760"/>
+        <location filename="mainwindow.cpp" line="862"/>
         <source>finished</source>
         <translation>Terminé</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="768"/>
+        <location filename="mainwindow.cpp" line="870"/>
         <source>Rsync process crashed</source>
         <translation>Le processus rsync à planté</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="780"/>
+        <location filename="mainwindow.cpp" line="882"/>
         <source>stopped by user</source>
         <translation>stoppé par l&apos;utilisateur</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="784"/>
+        <location filename="mainwindow.cpp" line="888"/>
         <source>Download </source>
         <translation>Téléchargement </translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="52"/>
+        <location filename="mainwindow.cpp" line="1237"/>
+        <source>RsyncUI Request</source>
+        <translation>Requête RsyncUI</translation>
+    </message>
+    <message>
+        <location filename="mainwindow.cpp" line="1238"/>
+        <source>Hidden service name</source>
+        <translation>Nom du servcice caché</translation>
+    </message>
+    <message>
+        <location filename="mainwindow.cpp" line="56"/>
         <source>Version</source>
         <translation>Version</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="51"/>
+        <location filename="mainwindow.cpp" line="55"/>
         <source>&lt;h2&gt;Client for rsync server&lt;/h2&gt;</source>
         <translation>&lt;h2&gt;Client pour serveur rsync&lt;/h2&gt;</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="53"/>
+        <location filename="mainwindow.cpp" line="57"/>
         <source>Licence</source>
         <translation>License</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="54"/>
+        <location filename="mainwindow.cpp" line="58"/>
         <source>Author</source>
         <translation>Auteur</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="55"/>
+        <location filename="mainwindow.cpp" line="59"/>
         <source>EMail</source>
         <translation>Courriel</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="56"/>
+        <location filename="mainwindow.cpp" line="60"/>
         <source>Source code</source>
         <translation>Code source</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="955"/>
+        <location filename="mainwindow.cpp" line="1053"/>
         <source>Since the save path is linked to service, you need to select a service before you can select a folder</source>
         <translation>Vous devez sélectionnez un service pour pouvoir sélectionnez un dossier par défaut</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="960"/>
+        <location filename="mainwindow.cpp" line="1058"/>
         <source>Choose folder where to save file</source>
         <translation>Choisissez un dossier où enregistrer le document</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="851"/>
+        <location filename="mainwindow.cpp" line="949"/>
         <source>Do you want to stop downloading and delete this file from download queue ?</source>
         <translation>Voulez-vous arrêter le téléchargement et enlever ce fichier de la file de téléchargement ?</translation>
     </message>
     <message>
-        <location filename="mainwindow.cpp" line="865"/>
+        <location filename="mainwindow.cpp" line="963"/>
         <source>Do you want to delete this file from download queue ?</source>
         <translation>Voulez-vous enlever ce fichier de la file de téléchargement ?</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="128"/>
+        <location filename="mainwindow.h" line="137"/>
         <source>The process failed to start. Either the invoked program is missing, or you may have insufficient permissions or resources to invoke the program.</source>
         <translation>Le processus échoué, soit le programme est manquant, soit vous n&apos;avez pas l&apos;autorisation de l&apos;exécuter.</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="129"/>
+        <location filename="mainwindow.h" line="138"/>
         <source>The process crashed some time after starting successfully.</source>
         <translation>Le processus à planté après avoir démarré avec succès.</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="130"/>
+        <location filename="mainwindow.h" line="139"/>
         <source>The last waitFor...() function timed out. The state of QProcess is unchanged, and you can try calling waitFor...() again.</source>
         <translation>La fonction waitFor...() a dépassé la limite de temps, you pouvez essayer de la relancer.</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="131"/>
+        <location filename="mainwindow.h" line="140"/>
         <source>An error occurred when attempting to write to the process. For example, the process may not be running, or it may have closed its input channel.</source>
         <translation>Une erreur est survenue lors de l&apos;envoi des données vers le processus. Le processus est peut être arrté ou il a fermé son canal d&apos;entrée.</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="132"/>
+        <location filename="mainwindow.h" line="141"/>
         <source>An error occurred when attempting to read from the process. For example, the process may not be running.</source>
         <translation>Une erreur est survenue lors de la lecturee de données, le processus est probablement arrêté.</translation>
     </message>
     <message>
-        <location filename="mainwindow.h" line="133"/>
+        <location filename="mainwindow.h" line="142"/>
         <source>An unknown error occurred. This is the default return value of error().</source>
         <translation>Une erreur inconnue est survenue. C&apos;est la valeur de retour par défaut de error().</translation>
     </message>

downloadfile.cpp

@@ -33,7 +33,7 @@ void MainWindow::cancelled(QProcess * process)
     n = process->waitForFinished(30000);
     if (n == false)
     {
-        process->kill();
+        process->close();
     }
 }
 
@@ -42,7 +42,15 @@ void MainWindow::download()
 {
     QString cmd;
     QStringList param;
+    QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
 
+    this->downloading.process = new QProcess(this);
+    if (!this->downloading.user.isEmpty())
+    {
+        this->downloading.server.prepend(this->connexion.user + "@");
+        env.insert("RSYNC_PASSWORD", this->downloading.password); // Add an environment variable
+        this->downloading.process->setProcessEnvironment(env);
+    }
     // Populating array with command and parameters for popen2
     cmd = "rsync";
     if (this->connexion.bandwidthLimit != 0)
@@ -53,7 +61,7 @@ void MainWindow::download()
     param << "-aXP";
     param << this->downloading.server + "::" + this->downloading.service + "/" + this->downloading.path << this->downloading.savePath + "/";
 
-    this->downloading.process = new QProcess(this);
+
 
     connect(this->downloading.process, SIGNAL(finished(int,QProcess::ExitStatus)), this, SLOT(downloadFinished(int, QProcess::ExitStatus)));
     //connect(this->downloading.process, SIGNAL(errorOccurred(QProcess::ProcessError error)), this, SLOT(downloadProcessError(QProcess::ProcessError error)));

login.ui

@@ -0,0 +1,144 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>LoginDialog</class>
+ <widget class="QDialog" name="LoginDialog">
+  <property name="windowModality">
+   <enum>Qt::ApplicationModal</enum>
+  </property>
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>400</width>
+    <height>194</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>RsyncUI request</string>
+  </property>
+  <property name="modal">
+   <bool>true</bool>
+  </property>
+  <widget class="QDialogButtonBox" name="loginBox">
+   <property name="geometry">
+    <rect>
+     <x>50</x>
+     <y>150</y>
+     <width>341</width>
+     <height>32</height>
+    </rect>
+   </property>
+   <property name="orientation">
+    <enum>Qt::Horizontal</enum>
+   </property>
+   <property name="standardButtons">
+    <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>
+   </property>
+  </widget>
+  <widget class="QWidget" name="verticalLayoutWidget">
+   <property name="geometry">
+    <rect>
+     <x>10</x>
+     <y>10</y>
+     <width>381</width>
+     <height>121</height>
+    </rect>
+   </property>
+   <layout class="QVBoxLayout" name="verticalLayout">
+    <item>
+     <widget class="QLabel" name="label">
+      <property name="text">
+       <string>Login name</string>
+      </property>
+      <property name="textFormat">
+       <enum>Qt::PlainText</enum>
+      </property>
+      <property name="textInteractionFlags">
+       <set>Qt::NoTextInteraction</set>
+      </property>
+     </widget>
+    </item>
+    <item>
+     <widget class="QLineEdit" name="loginEdit">
+      <property name="mouseTracking">
+       <bool>false</bool>
+      </property>
+      <property name="focusPolicy">
+       <enum>Qt::TabFocus</enum>
+      </property>
+      <property name="acceptDrops">
+       <bool>false</bool>
+      </property>
+      <property name="text">
+       <string/>
+      </property>
+      <property name="maxLength">
+       <number>32767</number>
+      </property>
+      <property name="placeholderText">
+       <string>Enter login</string>
+      </property>
+     </widget>
+    </item>
+    <item>
+     <widget class="QLabel" name="label_2">
+      <property name="text">
+       <string>Password</string>
+      </property>
+     </widget>
+    </item>
+    <item>
+     <widget class="QLineEdit" name="passwordEdit">
+      <property name="focusPolicy">
+       <enum>Qt::TabFocus</enum>
+      </property>
+      <property name="acceptDrops">
+       <bool>false</bool>
+      </property>
+      <property name="echoMode">
+       <enum>QLineEdit::Password</enum>
+      </property>
+      <property name="placeholderText">
+       <string>Enter password</string>
+      </property>
+     </widget>
+    </item>
+   </layout>
+  </widget>
+ </widget>
+ <resources/>
+ <connections>
+  <connection>
+   <sender>loginBox</sender>
+   <signal>accepted()</signal>
+   <receiver>LoginDialog</receiver>
+   <slot>accept()</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>248</x>
+     <y>254</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>157</x>
+     <y>274</y>
+    </hint>
+   </hints>
+  </connection>
+  <connection>
+   <sender>loginBox</sender>
+   <signal>rejected()</signal>
+   <receiver>LoginDialog</receiver>
+   <slot>reject()</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>316</x>
+     <y>260</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>286</x>
+     <y>274</y>
+    </hint>
+   </hints>
+  </connection>
+ </connections>
+</ui>

mainwindow.cpp

@@ -47,6 +47,10 @@ MainWindow::MainWindow(QWidget *parent)
     // init about window
     AboutW.setupUi(&aboutDialog);
 
+    //init login dialog
+    loginD.setupUi(&loginDialog);
+    loginD.loginEdit->setFocus();
+
     // text of About
     QString aboutText = tr("<h2>Client for rsync server</h2>") +
                         "<b>" + tr("Version") + ":     " + this->about.version + "</b><br>" +
@@ -66,6 +70,7 @@ MainWindow::MainWindow(QWidget *parent)
     connect(this, &MainWindow::stopDownloading, this, &MainWindow::cancelled);
     connect(config.buttonBox, SIGNAL(accepted()), this, SLOT(on_buttonBox_accepted()));
     connect(config.comboBox, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &MainWindow::on_comboBox_currentIndexChanged);
+    connect(loginD.loginBox, SIGNAL(accepted()), this, SLOT(on_loginBox_accepted()));
 
     // init of widgets
     ui->ktreewidgetsearchline->setTreeWidget(ui->treeWidget);               // attach search widget to treewidget
@@ -284,9 +289,9 @@ void MainWindow::populateTree(QTreeWidgetItem * parent)
         // validating server's address
         if (validateServer(this->connexion.server))
         {
-            // server is validated
-            path = ui->listWidget->currentItem()->text().section('\n', 0,  0) + "/";
-            scanDir(this->connexion.server, this->connexion.port, parent, path);
+            // server is validated, scanning directory
+            path = this->connexion.service + "/";
+           scanDir(this->connexion.server, this->connexion.port, parent, path);
         }
         // Restoring cursor
         QGuiApplication::restoreOverrideCursor();
@@ -297,7 +302,9 @@ void MainWindow::populateTree(QTreeWidgetItem * parent)
 void MainWindow::populateList()
 {
     QString server;
+    QStringList hidden;
     int port;
+    int i;
 
     server = ui->khistorycombobox->currentText();
     port = ui->portEdit->text().toUInt();
@@ -345,7 +352,14 @@ void MainWindow::populateList()
             }
         }
         this->settings.endGroup();
+        this->settings.beginGroup("Hidden/");
+        hidden = this->settings.allKeys();
+        for (i = 0; i < hidden.size(); i++)
+        {
+            ui->listWidget->addItem(this->settings.value(hidden.at(i)).toString() + "\n\t");
+        }
         QGuiApplication::restoreOverrideCursor();  //setting cursor to default
+        this->settings.endGroup();
     }
 }
 
@@ -392,11 +406,12 @@ void MainWindow::listServices()
     }
 
     // verifying error code
-    testRsyncReturn(myProcess);
+    testRsyncReturn(this, myProcess);
+    myProcess->close();
 }
 
 // connect to rsync server to get list of files
-void MainWindow::scanDir(QString server, int portN, QTreeWidgetItem *parent, QString path)
+bool MainWindow::scanDir(QString server, int portN, QTreeWidgetItem *parent, QString path)
 {
     QString cmd;
     QStringList param;
@@ -406,62 +421,94 @@ void MainWindow::scanDir(QString server, int portN, QTreeWidgetItem *parent, QSt
     QProcess * myProcess;
     bool isDir = false;
     bool flag = false;
+    bool readOk = false;
     int nChild = 0;
+    QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
 
-    if (parent != NULL)
+    myProcess = new QProcess(this);
+
+    if (parent != nullptr)
     {
         nChild = parent->childCount();
     }
     if (nChild == 0)
     {
+        if (!this->connexion.user.isEmpty())
+        {
+            server.prepend(this->connexion.user + "@");
+            env.insert("RSYNC_PASSWORD", this->connexion.password); // Add an environment variable
+        }else
+        {
+            server.prepend("anonymous@");
+            env.insert("RSYNC_PASSWORD", "anonymous"); // Add an environment variable
+        }
+        myProcess->setProcessEnvironment(env);
         cmd = "rsync";
         param << "--contimeout=10" << "--port=" + QString::number(portN) << server + "::" + path;
 
-        myProcess = new QProcess(this);
+
         myProcess->start(cmd, param);
 
-        // waiting for responsiteme of the server with a timeout of 10 seconds
-        while(myProcess->waitForReadyRead(100000))
+        // waiting for response of the server with a timeout of 10 seconds
+        do
         {
-            while (!flag)
+            readOk = myProcess->waitForReadyRead(10000);
+            if (readOk)
             {
-                line = QString::fromUtf8(myProcess->readLine());
-                // line empty then buffer is empty so returning to wait new datas
-                if (line.isEmpty())
+                while (!flag)
                 {
-                    flag = true;
-                    break;
-                }
-                // extracting name, size and is dir/file
-                line = line.simplified();
-                size = line.section(" ", 1, 1);
-                filename = line.section(" ", 4);
-                if (filename != '.')
-                {
-                    if (line[0] == "d")
+                    line = QString::fromUtf8(myProcess->readLine());
+                    // line empty then buffer is empty so returning to wait new datas
+                    if (line.isEmpty())
                     {
-                        isDir = true;
-                    }else
-                    {
-                        isDir = false;
+                        flag = true;
+                        break;
                     }
-                    if (parent != NULL)
+                    // extracting name, size and is dir/file
+                    line = line.simplified();
+                    size = line.section(" ", 1, 1);
+                    filename = line.section(" ", 4);
+                    if (filename != '.')
                     {
-                        //adding item to tree
-                        addTreeChild(parent, filename, size, isDir);
-                    }else
+                        if (line[0] == "d")
+                        {
+                            isDir = true;
+                        }else
+                        {
+                            isDir = false;
+                        }
+                        if (parent != NULL)
+                        {
+                            //adding item to tree
+                            addTreeChild(parent, filename, size, isDir);
+                        }else
+                        {
+                            //adding item to tree (as directory)
+                            addTreeRoot(filename, size, isDir);
+                        }
+                    }
+                }
+                flag = false;
+            }else
+            {
+                if (myProcess->state() == QProcess::Running)
+                {
+                    if (myProcess->waitForFinished(10000) == 0)
                     {
-                        //adding item to tree (as directory)
-                        addTreeRoot(filename, size, isDir);
+                        QMessageBox::warning(
+                            this,
+                            "RsyncUI",
+                            tr("The processus does'nt respond: ") + myProcess->errorString());
                     }
                 }
             }
-
-            flag = false;
-        }
+        }while(readOk);
         // buffer empty go to waiting new datas
-        testRsyncReturn(myProcess);
+
+        testRsyncReturn(this, myProcess);
+        myProcess->close();
     }
+    return 0;
 }
 
 // Verify if server address is IP address
@@ -540,6 +587,7 @@ bool MainWindow::validateServer(QString server)
             tr("server does not exists" )
         );
     }
+    myProcess->close();
     return flag;
 }
 
@@ -588,7 +636,7 @@ QTreeWidgetItem * MainWindow::addTreeChild(QTreeWidgetItem *parent, QString name
     }else
     {
         // item is a file
-        treeItem->setText(1,("File"));
+        treeItem->setText(1,tr("File"));
     }
     treeItem->setText(0, name);
     treeItem->setText(2, fileSize);
@@ -598,12 +646,21 @@ QTreeWidgetItem * MainWindow::addTreeChild(QTreeWidgetItem *parent, QString name
     return treeItem;
 }
 
-// Slot acivated when a service in the list is clicked
+// Slot activated when a service in the list is clicked
 void MainWindow::on_listWidget_clicked()
 {
-    QString str;
-
     this->connexion.service = ui->listWidget->currentItem()->text().section("\n", 0 ,0);
+    preparePopulateTree();
+}
+
+void MainWindow::preparePopulateTree()
+{
+    QString str;
+    QStringList logins;
+
+    this->rescan = true;
+    this->connexion.user = nullptr;
+    this->connexion.password = nullptr;
     str = "Folder/" + this->connexion.server + "/" + this->connexion.service;
     // if service exists in settings for this server
     if (this->settings.contains(str))
@@ -611,9 +668,50 @@ void MainWindow::on_listWidget_clicked()
         // setting savePath from settings
         this->downloading.savePath = this->settings.value(str).toString();
     }
+    this->settings.beginGroup("Passwords/" + this->connexion.server + "/" + this->connexion.service);
+    logins = this->settings.allKeys();
+        //TODO choose login
+    if (logins.count() != 0)
+    {
+        this->connexion.user = logins[0];
+        this->connexion.password = this->settings.value(logins[0]).toString();
+    }
+    this->settings.endGroup();
     populateTree(NULL);
 }
 
+// get password and user login
+// if object = false ==> searching from connexion object
+// else searching from downloading object
+bool MainWindow::getUserPassword(bool object = false)
+{
+    QStringList logins;
+    bool returnValue;
+
+    if (object == false)
+    {
+        this->settings.beginGroup("Passwords/" + this->connexion.server + "/" + this->connexion.service);
+    }else
+    {
+        this->settings.beginGroup("Passwords/" + this->downloading.server + "/" + this->downloading.service);
+    }
+    logins = this->settings.allKeys();
+    //TODO choose login in case of multiples logins
+    if (logins.count() != 0)
+    {
+        this->downloading.user = logins[0];
+        this->downloading.password = this->settings.value(logins[0]).toString();
+        returnValue = true;
+    }else
+    {
+        this->downloading.user = nullptr;
+        this->downloading.password = nullptr;
+        returnValue = false;
+    }
+    this->settings.endGroup();
+    return returnValue;
+}
+
 //Slot activated when a file is clicked in the treeview
 void MainWindow::on_treeWidget_itemClicked(QTreeWidgetItem *item, bool downloadDir)
 {
@@ -629,38 +727,40 @@ void MainWindow::on_treeWidget_itemClicked(QTreeWidgetItem *item, bool downloadD
 
     // assembling path from treewidget
     path = item->text(0);
-
-    // exists saving path in settings ?
-    str = "Folder/" + this->connexion.server + "/" + this->connexion.service;
-    if(!this->settings.contains(str))
-    {
-        // saving path do not exists, asking for it
-        if(!on_DefaultSaveFolder_triggered())
-        {
-            cout << "no directory selectioned, ignoring download request";
-            return;
-        }
-    }else
-    {
-        this->downloading.savePath = this->settings.value(str).toString();
-    }
-
+    sizeFromRsync = item->text(2).remove(',').toUInt();
 
     while(itemR->parent() != NULL)
     {
         itemR = itemR->parent();
         // concatening parent to path
         path.prepend(itemR->text(0) + "/");
-        sizeFromRsync = itemR->text(1).toUInt();
     };
-    QFileInfo info(path);
+
+    cout << item->text(1).toStdString() <<endl;
     if (item->text(1) == tr("File") or downloadDir == true)
     {
+        // exists saving path in settings ?
+        str = "Folder/" + this->connexion.server + "/" + this->connexion.service;
+        if(!this->settings.contains(str))
+        {
+            // saving path do not exists, asking for it
+            if(!on_DefaultSaveFolder_triggered())
+            {
+                cout << "no directory selectioned, ignoring download request";
+                return;
+            }
+        }else
+        {
+            this->downloading.savePath = this->settings.value(str).toString();
+        }
+
         // Item is a file
         // searching if file exists in savepath
         if (QFile::exists(this->downloading.savePath + "/" + path))
         {
-            if (info.size() >= sizeFromRsync)
+
+            QFileInfo info(this->downloading.savePath + "/" + path);
+            if (info.size() < sizeFromRsync)
             {
                 reply = QMessageBox::question(
                         this,
@@ -737,8 +837,10 @@ void MainWindow::on_treeWidget_itemClicked(QTreeWidgetItem *item, bool downloadD
 // Launch the thread which download the file
 void MainWindow::startDownloading()
 {
+
     ui->progressBar->setValue(0);
     ui->progressBar->show();
+    getUserPassword(false);
 
     //QtConcurrent::run(&this->downloadO, &downloadFile::download, this);
     this->download();
@@ -778,16 +880,18 @@ void MainWindow::downloadFinished(int exitCode, QProcess::ExitStatus exitStatus)
     }else if (exitCode == 20)
     {
         aborted = tr("stopped by user");
+    }else if (exitCode == 5)                            // password asked
+    {
+        loginDialog.show();
     }
 
-
     this->trayIcon->showMessage("RsyncUI", tr("Download ") + aborted + "\n" + this->downloading.path, QSystemTrayIcon::Information);
 
     // disconnecting signals to slots
     disconnect(this->downloading.process, 0, 0, 0);
 
     // reset variables and window
-    this->downloading.process = nullptr;
+    this->downloading.process->close();
     ui->progressBar->hide();
     delete ui->listDownload->takeItem(0);
     this->downloading.clear();
@@ -795,13 +899,6 @@ void MainWindow::downloadFinished(int exitCode, QProcess::ExitStatus exitStatus)
     // Some downloads staying in queue
     if (ui->listDownload->count() != 0)
     {
-        // autosave is activated
-        /*if (config.autosaveCheckbox->checkState() == Qt::Checked)
-        {
-            // saving download list
-            saveDownloadList();
-        }*/
-
         // initializing download
         path = ui->listDownload->item(0)->text();
         pos = path.lastIndexOf("/");
@@ -811,6 +908,7 @@ void MainWindow::downloadFinished(int exitCode, QProcess::ExitStatus exitStatus)
         this->downloading.server = path.midRef(pos+4).toString();
         path.resize(pos);
         this->downloading.path = path;
+        getUserPassword(true);
 
         // savepath exists in settings ?
         str = "Folder/" + this->downloading.server + "/" + this->downloading.service;
@@ -1069,6 +1167,11 @@ void Downloading::clear()
     this->server.clear();
     this->savePath.clear();
     this->service.clear();
+    this->user.clear();
+    this->password.clear();
+    this->port = 0;
+    this->process = nullptr;
+    this->quit = false;
 }
 
 // Context menu of file list clicked
@@ -1102,7 +1205,42 @@ void MainWindow::on_actionExit_triggered()
     quitApp();
 }
 
+void MainWindow::on_loginBox_accepted()
+{
+    if (!loginD.loginEdit->text().isEmpty())
+    {
+        this->connexion.user = loginD.loginEdit->text();
+        if (!loginD.passwordEdit->text().isEmpty())
+        {
+            this->connexion.password = loginD.passwordEdit->text();
+            this->settings.setValue("Passwords/" + this->connexion.server + "/" + this->connexion.service + "/" + this->connexion.user, this->connexion.password);
+            this->settings.sync();
+            if (this->rescan == true)
+            {
+                this->rescan = false;
+                populateTree(NULL);
+            }
+        }
+    }
+}
+
 void MainWindow::setDlSpeed(QString speed)
 {
     speed.squeeze();
 }
+
+void MainWindow::on_actionHiddenService_triggered()
+{
+    QInputDialog hiddenFolderDialog;
+
+    bool ok;
+    QString text = QInputDialog::getText(this, tr("RsyncUI Request"),
+                                         tr("Hidden service name"), QLineEdit::Normal,
+                                         "test", &ok);
+    if (ok && !text.isEmpty())
+    {
+        this->connexion.service = text;
+        this->settings.setValue("Hidden/" + this->connexion.server, text);
+        preparePopulateTree();
+    }
+}

mainwindow.h

@@ -5,6 +5,7 @@
 #include "ui_mainwindow.h"
 #include "ui_configuration.h"
 #include "ui_about.h"
+#include "ui_login.h"
 #include "downloadfile.h"
 #include "tools.h"
 #include <QMainWindow>
@@ -43,7 +44,8 @@
 #include <QDir>
 #include <QSystemTrayIcon>
 #include <QMenu>
-#include<QTranslator>
+#include <QTranslator>
+#include <QInputDialog>
 
 QT_BEGIN_NAMESPACE
 namespace Ui { class MainWindow; }
@@ -58,6 +60,8 @@ class Connexion
         int bandwidthLimitUnit;
         QString server;
         QString service;
+        QString user;
+        QString password;
         int port = 873;
         bool comboboxChanged;
 };
@@ -69,7 +73,9 @@ class Downloading
         QString service;
         QString path;
         QString savePath;
-        int port;
+        QString user;
+        QString password;
+        int port = 873;
         QProcess * process = nullptr;
         bool quit = false;
         void clear();
@@ -79,7 +85,7 @@ class About
 {
     public:
         QString title = "RsyncUI";
-        QString version = "2.5";
+        QString version = "2.7";
         QString author = "Daniel TARTAVEL-JEANNOT";
         QString licence = "GPL_V3";
         QString description;
@@ -98,16 +104,19 @@ class MainWindow : public QMainWindow
         QProgressDialog *progress;
         Connexion connexion;
         Downloading downloading;
-        //downloadFile downloadO;
         QSettings settings;
         About about;
         QDialog Configuration;
         Ui::Configuration config;
         QDialog aboutDialog;
         Ui::windowAbout AboutW;
+        QDialog loginDialog;
+        Ui::LoginDialog loginD;
         std::vector <QString> serversList;
         QSystemTrayIcon * trayIcon;
         QString icon = "/usr/share/icons/RsyncUI.png";
+        bool rescan = false;
+
         QList<QString> bwUnitText {
             "KB",
             "MB",
@@ -141,7 +150,7 @@ class MainWindow : public QMainWindow
         bool isIpAddress(QString server);
         QTreeWidgetItem * addTreeRoot(QString name, QString description, bool isDir);
         QTreeWidgetItem * addTreeChild(QTreeWidgetItem *parent, QString name, QString size, bool isDir);
-        void scanDir(QString server, int portN, QTreeWidgetItem *parent = NULL, QString path = "" );
+        bool scanDir(QString server, int portN, QTreeWidgetItem *parent = NULL, QString path = "" );
         void startDownloading();
         void loadSettings();
         void saveSettings();
@@ -153,6 +162,8 @@ class MainWindow : public QMainWindow
         void hideWindow();
         void showWindow();
         void init();
+        bool getUserPassword(bool);
+        void preparePopulateTree();
 
     private slots:
 
@@ -202,6 +213,10 @@ class MainWindow : public QMainWindow
 
         void setDlSpeed(QString speed);
 
+        void on_loginBox_accepted();
+
+        void on_actionHiddenService_triggered();
+
 signals:
         void stopDownloading(QProcess *);
         void progressSignal(int);

mainwindow.ui

@@ -275,10 +275,10 @@
             <bool>false</bool>
            </property>
            <property name="dragEnabled">
-            <bool>true</bool>
+            <bool>false</bool>
            </property>
            <property name="dragDropMode">
-            <enum>QAbstractItemView::DragOnly</enum>
+            <enum>QAbstractItemView::NoDragDrop</enum>
            </property>
            <property name="alternatingRowColors">
             <bool>true</bool>
@@ -399,6 +399,7 @@
     <bool>false</bool>
    </attribute>
    <addaction name="DefaultSaveFolder"/>
+   <addaction name="actionHiddenService"/>
    <addaction name="action_Settings"/>
    <addaction name="actionAbout"/>
    <addaction name="actionAbout_Qt"/>
@@ -466,6 +467,14 @@
     <string>Ctrl+Q</string>
    </property>
   </action>
+  <action name="actionHiddenService">
+   <property name="icon">
+    <iconset theme="folder-open"/>
+   </property>
+   <property name="text">
+    <string>hidden service</string>
+   </property>
+  </action>
  </widget>
  <customwidgets>
   <customwidget>

tools.cpp

@@ -44,7 +44,7 @@ const vector<string> explode(const string& s, const char& c, int n = 0)
 }
 
 // test return code of rsync
-bool testRsyncReturn(QProcess * myProcess)
+bool testRsyncReturn(MainWindow * w, QProcess * myProcess)
 {
     if (myProcess->exitStatus() != 0)
     {
@@ -55,6 +55,9 @@ bool testRsyncReturn(QProcess * myProcess)
                    QMessageBox::Ok,
                    QMessageBox::Ok);
         return true;
+    }else if (myProcess->exitCode() == 5)
+    {
+        w->loginDialog.show();
     }else if (myProcess->exitCode() != 0)
     {
         QMessageBox::warning(
@@ -67,3 +70,5 @@ bool testRsyncReturn(QProcess * myProcess)
     }
     return false;
 }
+
+

tools.h

@@ -1,6 +1,7 @@
 #ifndef TOOLS_H
 #define TOOLS_H
 
+#include "mainwindow.h"
 #include <string>
 #include <vector>
 #include <array>
@@ -17,7 +18,6 @@ FILE * popen2(array<string,8> argv, string type, int & pid);
 
 int pclose2(FILE * fp, pid_t pid);
 
-bool testRsyncReturn(QProcess *);
-
+bool testRsyncReturn(MainWindow *, QProcess *);
 
 #endif // TOOLS_H